commit 8159ea4c11b3fcad0072500328009a4a62f41bc5
parent 396f647ba1bdd15e2cf5e15a4f2246e45c5b225e
Author: Amit Dutta <mail@amit.is-a.dev>
Date: Wed, 1 Jul 2026 09:03:05 +0530
Reorder and renumber PR review criteria
Diffstat:
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/maintainers/reviewing-prs.md b/src/maintainers/reviewing-prs.md
@@ -17,10 +17,10 @@ You should instantly close a pull request when:
3. The PR is requesting NS records without a valid reason or without a reason provided at all. See [this page](https://docs.is-a.dev/faq/#who-can-use-ns-records) for details on what we consider a valid reason to request NS records.
4. The user violates our ToS in any way; e.g., if they are under thirteen years of age, if their webpage is breaking the law or hosting illegal content, cryptocurrency mining sites or tools, impersonation without consent, et cetera.
5. The webpage is not related to software development. This does not apply for nested subdomains![^1]
-5. Webpages who want to use our subdomain for commercial purposes. Including but not limited to *anything* with a "pricing plan" page. A portfolio stating that the user is available for hire is not considered commercial usage.
-6. The user breaks GitHub's [Terms of Service](https://docs.github.com/en/site-policy/github-terms/github-terms-of-service).
-7. The PR is a duplicate of another PR (i.e., the user made multiple PRs in the hopes of getting their domain faster).
-8. Any one the "Requirements" checkboxes have not been fulfilled.
+6. Webpages who want to use our subdomain for commercial purposes. Including but not limited to *anything* with a "pricing plan" page. A portfolio stating that the user is available for hire is not considered commercial usage.
+7. The user breaks GitHub's [Terms of Service](https://docs.github.com/en/site-policy/github-terms/github-terms-of-service).
+8. The PR is a duplicate of another PR (i.e., the user made multiple PRs in the hopes of getting their domain faster).
+9. Any one the "Requirements" checkboxes have not been fulfilled.
## Steps to Reviewing a PR
First, approve checks if needed. Do this by clicking the button at the bottom of the PR labelled "Approve workflows to run".
@@ -51,4 +51,4 @@ You can use quickly select and use saved replies in the reply/reviewing text box
3. When unsure of whether or not to approve or request changes on a PR, do not hesitate to ask another, more experienced maintainer on how to deal with it. You can also simply skip the PR and wait for someone else to review it.
-[^1]: Nested subdomains are a subdomain of a subdomain, such as `nested.example.is-a.dev`. `example.is-a.dev` is not a nested subdomain, it is a subdomain!
-\ No newline at end of file
+[^1]: Nested subdomains are a subdomain of a subdomain, such as `nested.example.is-a.dev`. `example.is-a.dev` is not a nested subdomain, it is a subdomain!
